Purge type HTTP just does not work#22
Merged
andrerom merged 1 commit intoezsystems:masterfrom Nov 6, 2017
Plopix:patch-1
Merged
Purge type HTTP just does not work#22andrerom merged 1 commit intoezsystems:masterfrom Plopix:patch-1
andrerom merged 1 commit intoezsystems:masterfrom
Plopix:patch-1
Conversation
2 tasks
Contributor
Author
|
ping @vidarl @andrerom @bdunogier |
bdunogier
approved these changes
Nov 6, 2017
Contributor
bdunogier
left a comment
bdunogier
left a comment
There was a problem hiding this comment.
Thanks a lot for this. It looks very valid to me.
which also mean, that this feature was not tested.
The package is still experimental, as indicated in the README.
It would be good to add a Unit Test for this compiler pass. It would document which services are meant to be replaced, instead of reverse engineering the code itself.
Contributor
Author
But it is enabled by default in the last stable 1.12. Cool this PR helped! |
vidarl
added a commit
to vidarl/ezplatform-http-cache
that referenced
this pull request
Nov 7, 2017
This reverts commit 6b1dafa.
vidarl
added a commit
to vidarl/ezplatform-http-cache
that referenced
this pull request
Nov 15, 2017
This reverts commit 6b1dafa.
andrerom
pushed a commit
that referenced
this pull request
Nov 17, 2017
* Revert "Allows http purge type to work (#22)" This reverts commit 6b1dafa. * Added plugin support for purge clients * Renamed FOSPurgeClient.php to VarnishPurgeClient.php * Added plugin support for TagHandler * Updated declaration of PurgeClientInterface * Added doc on how to write http cache drivers * Changed DI alias to ez_platform_cache by renaming EzSystemsPlatformHttpCacheExtension class * Updated composer.json as we depend on ezpublish-kernel PR #2136 * Changed to single quites on services.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bundle relies on
ezplatform.http_cache.purge_clientbut the code in ez kernel setsezpublish.http_cache.purge_clientWiring has not been done, which also mean, that this feature was not tested.