Update linking.md (remove override keyword that make build fail in last RN version)#4684
Update linking.md (remove override keyword that make build fail in last RN version)#4684LaGregance wants to merge 1 commit intofacebook:mainfrom
Conversation
Remove "override" keyword as AppDelegate inherit directly from UIApplicationDelegate that is a protocol, using override cause error "Method does not override any method from its superclass"
|
Hi @LaGregance! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
LaGregance
changed the title
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
hey @LaGregance 👋 do you know who should we tag to get this merged? |
3 participants
Remove "override" keyword as AppDelegate inherit directly from UIApplicationDelegate that is a protocol, using override cause error "Method does not override any method from its superclass".