Add annotate-pr.yml workflow to replace danger-pr #55341
+138
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@emily8rown has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90991845. |
emily8rown
force-pushed
the
export-D90991845
branch
from
769ce22 to
59b9f3b
Compare
emily8rown
added a commit
to emily8rown/react-native
that referenced
this pull request
Jan 28, 2026
Summary: [RN][CI] Add annotate-pr.yml workflow with generic PR comment action Creates a new GitHub Actions workflow that will eventually replace `danger-pr.yml` for annotating PRs with various quality checks. The workflow: - Triggers on `pull_request_target` for opened, edited, reopened, and synchronize events - Checks out the main branch (for security, using trusted code) - Runs the `diff-js-api-changes` action to detect API changes - Posts a PR comment using the generic `post-pr-comment` action The PR comment script creates, updates, or deletes a bot comment based on whether there are any sections to report, using a marker to identify existing bot comments. Differential Revision: D90991845
emily8rown
added a commit
to emily8rown/react-native
that referenced
this pull request
Jan 28, 2026
Summary: Creates a new GitHub Actions workflow that will eventually replace `danger-pr.yml` for annotating PRs with various quality checks. The workflow: - Triggers on `pull_request_target` for opened, edited, reopened, and synchronize events - Checks out the main branch (for security, using trusted code) - Runs the `diff-js-api-changes` action to detect API changes - Posts a PR comment using the generic `post-pr-comment` action The PR comment script creates, updates, or deletes a bot comment based on whether there are any sections to report, using a marker to identify existing bot comments. Differential Revision: D90991845
emily8rown
force-pushed
the
export-D90991845
branch
2 times, most recently
from
bf63123 to
f2901e7
Compare
emily8rown
added a commit
to emily8rown/react-native
that referenced
this pull request
Jan 29, 2026
Summary: Creates a new GitHub Actions workflow that will eventually replace `danger-pr.yml` for annotating PRs with various quality checks. The workflow: - Triggers on `pull_request_target` for opened, edited, reopened, and synchronize events - Checks out the main branch (for security, using trusted code) - Runs the `diff-js-api-changes` action to detect API changes - Posts a PR comment using the generic `post-pr-comment` action The PR comment script creates, updates, or deletes a bot comment based on whether there are any sections to report, using a marker to identify existing bot comments. Reviewed By: huntie Differential Revision: D90991845
emily8rown
added a commit
to emily8rown/react-native
that referenced
this pull request
Jan 29, 2026
Summary: Creates a new GitHub Actions workflow that will eventually replace `danger-pr.yml` for annotating PRs with various quality checks. The workflow: - Triggers on `pull_request_target` for opened, edited, reopened, and synchronize events - Checks out the main branch (for security, using trusted code) - Runs the `diff-js-api-changes` action to detect API changes - Posts a PR comment using the generic `post-pr-comment` action The PR comment script creates, updates, or deletes a bot comment based on whether there are any sections to report, using a marker to identify existing bot comments. Reviewed By: huntie Differential Revision: D90991845
emily8rown
force-pushed
the
export-D90991845
branch
from
f2901e7 to
2bcc697
Compare
) Summary: Changelog: [INTERNAL] [FIXED] - Fix diff-js-api-changes workflow to correctly compare PR head vs merge base The `diff-js-api-changes` action was comparing main to main instead of comparing the PR head to the point of main it branched from. The workflow now: 1. Checks out main in `danger-pr.yml` to get the trusted scripts 2. Fetches the PR head commit and computes the merge base (the point it branched from main) 3. Extracts the API snapshots from both refs using `git show` to read-only temp files 4. Runs main's diff script to compare the two snapshots **Security notes:** - `git fetch` only downloads git objects, it does not modify the working directory - `git show <sha>:path` extracts a file as read-only data, not executable code - All executed scripts come from main (trusted), PR content is only used as data - The PR's `.d.ts` file is written to a temp directory and passed as input to main's diff script Reviewed By: huntie Differential Revision: D90978905
Summary: Creates a new GitHub Actions workflow that will eventually replace `danger-pr.yml` for annotating PRs with various quality checks. The workflow: - Triggers on `pull_request_target` for opened, edited, reopened, and synchronize events - Checks out the main branch (for security, using trusted code) - Runs the `diff-js-api-changes` action to detect API changes - Posts a PR comment using the generic `post-pr-comment` action The PR comment script creates, updates, or deletes a bot comment based on whether there are any sections to report, using a marker to identify existing bot comments. Reviewed By: huntie Differential Revision: D90991845
emily8rown
force-pushed
the
export-D90991845
branch
from
2bcc697 to
2a4a34c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
[RN][CI] Add annotate-pr.yml workflow with generic PR comment action
Creates a new GitHub Actions workflow that will eventually replace
danger-pr.ymlfor annotating PRs with various quality checks.
The workflow:
pull_request_targetfor opened, edited, reopened, and synchronize eventsdiff-js-api-changesaction to detect API changespost-pr-commentactionThe PR comment script creates, updates, or deletes a bot comment based on whether
there are any sections to report, using a marker to identify existing bot comments.
Differential Revision: D90991845