Skip to content

Conversation

@mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Jan 29, 2026

Summary:
Fixed ReflectionMethodUse lint error in AnimationDriver.kt.

Replaced javaClass.simpleName with a hardcoded string to avoid reflection
which can cause issues with Redex obfuscation in production builds.

changelog: [internal] internal

Differential Revision: D91736698

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 29, 2026
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jan 29, 2026
Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync
Copy link

meta-codesync bot commented Jan 29, 2026

@mdvacca has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91736698.

mdvacca added a commit to mdvacca/react-native that referenced this pull request Jan 29, 2026
…essage (facebook#55359)

Summary:

Fixed ReflectionMethodUse lint error in AnimationDriver.kt.

Replaced `javaClass.simpleName` with a hardcoded string to avoid reflection
which can cause issues with Redex obfuscation in production builds.

changelog: [internal] internal

Differential Revision: D91736698
mdvacca added a commit to mdvacca/react-native that referenced this pull request Jan 29, 2026
…essage (facebook#55359)

Summary:

Fixed ReflectionMethodUse lint error in AnimationDriver.kt.

Replaced `javaClass.simpleName` with a hardcoded string to avoid reflection
which can cause issues with Redex obfuscation in production builds.

changelog: [internal] internal

Differential Revision: D91736698
mdvacca added a commit to mdvacca/react-native that referenced this pull request Jan 29, 2026
…essage (facebook#55359)

Summary:

Fixed ReflectionMethodUse lint error in AnimationDriver.kt.

Replaced `javaClass.simpleName` with a hardcoded string to avoid reflection
which can cause issues with Redex obfuscation in production builds.

changelog: [internal] internal

Differential Revision: D91736698
…k#55360)

Summary:

Fixed FieldsBelowInit lint errors in ColorAnimatedNode.kt.

Moved `color` and `context` computed properties above the init block to follow
Kotlin initialization order conventions and prevent potential initialization issues.

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D91736974
…ebook#55361)

Summary:

Fixed FieldsBelowInit lint error in DiffClampAnimatedNode.kt.

Moved `inputNodeValue` computed property above the init block to follow
Kotlin initialization order conventions.

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D91737148
…ger error messages (facebook#55362)

Summary:

Fixed ReflectionMethodUse lint errors in NativeAnimatedNodesManager.kt.

Replaced `::class.java.name` reflection calls with hardcoded class names in
error messages to avoid issues with Redex obfuscation in production builds.

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D91738126
…k#55363)

Summary:

Fixed FieldsBelowInit lint error in PropsAnimatedNode.kt.

Moved `connectedView` computed property above the init block to follow
Kotlin initialization order conventions.

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D91738282
Summary:

Fixed multiple lint issues in SpringAnimation.kt:

1. FieldsBelowInit: Moved isAtRest and isOvershooting computed properties
   above the init block to follow Kotlin initialization order conventions.

2. MixedConditionalOperators: Added explicit parentheses to clarify operator
   precedence in boolean expressions mixing && and ||.

changelog: [internal] internal

Reviewed By: javache

Differential Revision: D91738503
…essage (facebook#55359)

Summary:

Fixed ReflectionMethodUse lint error in AnimationDriver.kt.

Replaced `javaClass.simpleName` with a hardcoded string to avoid reflection
which can cause issues with Redex obfuscation in production builds.

changelog: [internal] internal

Differential Revision: D91736698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants