-
Notifications
You must be signed in to change notification settings - Fork 50.4k
[Flight] Forward early debug info for lazy chunks #35506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lubieowoce
wants to merge
5
commits into
facebook:main
Choose a base branch
from
lubieowoce:reencode-debug-info
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+587
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8363558 to
f4651dc
Compare
b6057e3 to
bb3681d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when we're re-encoding a lazy chunk that came from a flight stream, we wait for the chunk to resolve, and then forward the debug info. This unnecessarily delays debug info that's already available while the chunk is still pending, like stack info. This PR attempts to make it so that we emit whatever debug info we have before initializing the lazy chunk (which may suspend), and then emit the rest after.
When a debug info array is partially emitted, we save the entries we already emitted in a WeakSet
request.earlyDebugInfoEntries. That way, when we emit it again later, we know which entries to skip.Notably, we need to track individual entries, because they might get transferred from the lazy chunk onto the inner element (i.e. moved to a different array):
react/packages/react-client/src/ReactFlightClient.js
Lines 1275 to 1291 in b546603
(Originally, i had a WeakMap that tracked a "emitted entries count" per debug info array, but this didn't account for moving entries into a different array)
Most debug infos are not partially emitted -- we currently only do this for lazy elements -- so to avoid the overhead of tracking each entry we only do this if it's emitted using
forwardDebugInfoOnce.