[compiler] Fix Symbol shadowing by prefixing with globalThis
#35553
+675
−627
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #35379
The React compiler currently emits code that produces a runtime error when the global
Symbolis being shadowed by another reference namedSymbol. This PR changes the emitted code to accessSymbolviaglobalThis.Symbolto fix this issue.Thanks to #35429 for providing a hint to the fix, but this PR also applies the fix to
PropagateEarlyReturnsandInlineJsxTransform.How did you test this change?
All related test fixtures are updated with this change. Some examples of the generated code:
if ($[0] !== props.a || $[1] !== props.b || $[2] !== props.cond) { - t0 = Symbol.for("react.early_return_sentinel"); + t0 = globalThis.Symbol.for("react.early_return_sentinel"); bb0: {