Optimize eslint-plugin-react-hooks for large codebases #35572
+70
−41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #35395
This PR addresses severe performance issues in
eslint-plugin-react-hooksv7.0.1, particularly with compiler rules likestatic-componentswhich were consuming 56%+ of total lint time on large codebases (~15k+ files).Problem
On large codebases, the
static-componentsrule alone was taking 393 seconds (56.2% of total lint time), making ESLint runs take twice as long (3 min → 6 min).Root Causes
isDeepStrictEqual()checks on every cache lookupChanges Made
1. Pre-grouped Events by Category
eventsByCategory: Map<string, Array<LoggerEvent>>to cache entries2. Improved Cache Key Strategy
isDeepStrictEqual()calls${filename}:${sourceHash}:${optsHash}3. Increased Cache Size
4. Optimized Rule Event Processing
Expected Impact
Test Plan
Files Modified
packages/eslint-plugin-react-hooks/src/shared/RunReactCompiler.tspackages/eslint-plugin-react-hooks/src/shared/ReactCompiler.ts🤖 Generated with Claude Code