Add a typed parameter for the failure in FailurePolicy.handleIf#288
Open
jhalterman wants to merge 1 commit intomasterfrom
Open
Add a typed parameter for the failure in FailurePolicy.handleIf#288jhalterman wants to merge 1 commit intomasterfrom
jhalterman wants to merge 1 commit intomasterfrom
Conversation
jhalterman
force-pushed
the
typed-handleif
branch
from
052d55f to
bb206a5
Compare
Contributor
|
After code is missing method name, should be: policy.<HttpException>handleIf((result, failure) -> failure.isServerError()); |
Member
Author
|
🤦 thanks, edited. |
jhalterman
force-pushed
the
master
branch
8 times, most recently
from
5cae083 to
ad163c1
Compare
jhalterman
force-pushed
the
master
branch
3 times, most recently
from
25161a9 to
5ef8514
Compare
jhalterman
force-pushed
the
master
branch
9 times, most recently
from
5356370 to
86fffa9
Compare
jhalterman
force-pushed
the
master
branch
2 times, most recently
from
25c24a0 to
8b50fa3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small improvement, though I'm not sure if it's worth doing. Thoughts?
--
This is meant to make it slightly (maybe? arguably?) easier to write FailurePolicy.handleIf statements that are specifically typed. Ex:
Before
After
This could open the door for ClassCastExceptions, but those are ignored by FailurePoilicy: https://github.com/failsafe-lib/failsafe/blob/master/src/main/java/net/jodah/failsafe/FailurePolicy.java#L160-L162