Skip to content

Conversation

@tobiase
Copy link
Contributor

@tobiase tobiase commented Oct 5, 2024

This change will prompt developers to install the MJML extension when they open the project in vscode.

.gitignore Outdated
@@ -1,4 +1,5 @@
.vscode
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering why .vscode is excluded since it already contains a launch config.

@alejsdev alejsdev changed the title Add MJML extension to recommended vscode workspace extensions 🔧 Add MJML extension to recommended vscode workspace extensions Oct 24, 2024
@tobiase tobiase force-pushed the add-mjml-to-recommended-vscode-extensions branch from 2f6648f to 302f10c Compare November 7, 2024 10:18
Copy link
Member

@YuriiMotov YuriiMotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tobiase and others added 2 commits September 4, 2025 21:26
Co-authored-by: Motov Yurii <109919500+YuriiMotov@users.noreply.github.com>
@YuriiMotov YuriiMotov changed the title 🔧 Add MJML extension to recommended vscode workspace extensions 🔧 Add recommended extension to vscode workspace extensions Oct 10, 2025
"attilabuti.vscode-mjml",
"ms-python.python",
"ms-python.debugpy",
"elagil.pre-commit-helper",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be an extra extension not specifically related to the project, I would remove this one, please.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove elagil.pre-commit-helper, right?
Done)

@tiangolo tiangolo changed the title 🔧 Add recommended extension to vscode workspace extensions 🔧 Add recommended VS Code extensions Jan 22, 2026
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

I just updated it to reference the new official MJML extension, also the docs about it.

And I updated it to include all the extensions I would recommend right now for this project.

@tiangolo tiangolo enabled auto-merge (squash) January 22, 2026 20:08
@tiangolo tiangolo merged commit 4c65c01 into fastapi:master Jan 22, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants