-
-
Notifications
You must be signed in to change notification settings - Fork 8k
🔧 Add recommended VS Code extensions #1386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 Add recommended VS Code extensions #1386
Conversation
.gitignore
Outdated
| @@ -1,4 +1,5 @@ | |||
| .vscode | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering why .vscode is excluded since it already contains a launch config.
2f6648f to
302f10c
Compare
YuriiMotov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Motov Yurii <109919500+YuriiMotov@users.noreply.github.com>
.vscode/extensions.json
Outdated
| "attilabuti.vscode-mjml", | ||
| "ms-python.python", | ||
| "ms-python.debugpy", | ||
| "elagil.pre-commit-helper", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be an extra extension not specifically related to the project, I would remove this one, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove elagil.pre-commit-helper, right?
Done)
tiangolo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🚀
I just updated it to reference the new official MJML extension, also the docs about it.
And I updated it to include all the extensions I would recommend right now for this project.
This change will prompt developers to install the MJML extension when they open the project in vscode.