Skip to content

Conversation

@mdboom
Copy link
Contributor

@mdboom mdboom commented Jun 9, 2025

No description provided.

@mdboom mdboom requested a review from Copilot June 9, 2025 19:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures that benchmark results aren’t inadvertently reused by clearing the cache before parsing, and adds a sanity check to enforce that the “good” timing is strictly less than the “bad” timing during a bisect run.

  • Clears the cached JSON load before computing each result to avoid stale data.
  • Validates timing order and displays the bisect log on failure.
Comments suppressed due to low confidence (1)

bench_runner/scripts/bisect.py:127

  • This new validation branch needs corresponding test cases to ensure the ValueError is raised and the log is shown when good_timing is not less than bad_timing.
if good_timing >= bad_timing:

@mdboom mdboom merged commit ccc2aa2 into faster-cpython:main Jun 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant