Draft
Conversation
Member
|
how much perf would this get us? |
Contributor
Author
|
I am still investigating |
Eomm
reviewed
Jul 27, 2023
lib/optimize.js
Outdated
| @@ -0,0 +1,87 @@ | |||
| 'use strict' | |||
|
|
|||
| const serializerReturnRE = /^return ([a-zA-Z0-9]+)\(\w+\)$/ | |||
Member
There was a problem hiding this comment.
How do you write this code?
Do you follow some automation?
Only AI will be able to read it tho
Contributor
Author
There was a problem hiding this comment.
Manually. Writing my unit test, then adapt to what I prefer.
401efc3 to
592b3e7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
PR: MASTER: |
2 tasks
Contributor
|
@Uzlopak this PR looks very interesting, why not keep working on it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct