Open
Conversation
Member
|
What is being put up "again for discussion"? |
Eomm
reviewed
Sep 22, 2024
Member
Eomm
left a comment
Eomm
left a comment
There was a problem hiding this comment.
This is a perf PR, did you share some result in other issues that I missed?
Contributor
Author
|
Since the last parameter can be cause fastify error is limitted to the fixed amount of placeholders. As long as we dont use %o and %O placeholders we can generate format functions which are isomorph. On the other hand, we could actually implement a solution to avoid the issue #134. |
Member
|
I really don't understand why we would want to get into the business of maintaining a format string interpolator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
putting this again for discussion