Added parameters for custom glob patterns and glob options...#375
Open
yaneony wants to merge 5 commits intofastify:mainfrom
Open
Added parameters for custom glob patterns and glob options...#375yaneony wants to merge 5 commits intofastify:mainfrom
yaneony wants to merge 5 commits intofastify:mainfrom
Conversation
…o preserving backward compatibility with the serveDotFiles option provided by the plugin.
Author
|
Test do fail because of previous commits. Even freshly cloned repository fail. Who gonna fix that? |
mcollina
requested changes
Apr 19, 2023
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
Thanks for opening a PR! Can you please add a unit test?
Fdawgs
requested changes
Apr 19, 2023
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Contributor
|
Well, without unit tests the CI CD Pipeline will fail, because we expect 100% test coverage. |
mcollina
requested changes
May 15, 2023
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
Thanks for opening a PR! Can you please add a unit test?
Member
|
A test is still missing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added parameters for custom glob patterns and glob options, while also preserving backward compatibility with the serveDotFiles option provided by the plugin. As of #178
Checklist
npm run testandnpm run benchmarkand the Code of conduct