SonicTriton: implement RetryActionDiffServer via TritonService; add tests and cfg support#23
Draft
trevin-lee wants to merge 1 commit intofastmachinelearning:masterfrom
Draft
Conversation
…end tests; add Catch2 unit test; update tritonTest_cfg.py for retry policy logging; ported to CMSSW_15_1_0_pre3 base
kakwok
reviewed
Sep 10, 2025
| void postModuleConstruction(edm::ModuleDescription const&); | ||
| void preModuleDestruction(edm::ModuleDescription const&); | ||
| void preBeginJob(edm::ProcessContext const&); | ||
| void preBeginJob(edm::PathsAndConsumesOfModulesBase const&, edm::ProcessContext const&); |
There was a problem hiding this comment.
@trevin-lee This change would prevent the code from compiling. Are these some un-wanted changes from a developing branch.
trevin-lee
pushed a commit
to trevin-lee/cmssw
that referenced
this pull request
Sep 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
RetryActionDiffServerfor SonicTriton usingTritonService’s server registry; remove per-action alternate server parameters.TritonClient::updateServer(TritonService::Server::fallbackName)to switch servers on retry, per review guidance.HeterogeneousCore/SonicTriton/test/test_RetryActionDiffServer.cc(arms → updateServer(fallback) → no-op on second retry → exception path is caught).HeterogeneousCore/SonicTriton/test/tritonTest_cfg.pywith--retryAction {same,diff}and a verbose confirmation line.TestHeterogeneousCoreSonicTritonRetryActionDiff_Logto assert the selected retry policy.HeterogeneousCore/SonicTriton/test/BuildFile.xml(remove package-level test entries; use proper<bin>withcatch2).TritonClient(test double support), removing the unused testing flag constructor.PR validation:
CMSSW_15_1_0_pre3area:scram b -j 8scram b runtests TEST=HeterogeneousCore/SonicTriton(passes)sameanddiffpolicies.Client.Retryis explicitly configured.Backport:
CMSSW_15_0_Xafter this PR is reviewed.