generated from fdnd/task
-
Notifications
You must be signed in to change notification settings - Fork 115
JS for header #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yamenAl
wants to merge
104
commits into
fdnd-task:main
Choose a base branch
from
Recss68:Feature/Header
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
JS for header #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is the main code for the header.
here the main code for the header where we navigation to other rouwtaak
test for pull req
header/dropdown ( Gecontroleerd door Recep )
Hier code voor die foot, footer en die head van de website
Dit is die code voor die error paga zonder css
Here the first code for the exercise page still need to add loop and classes
Implement classes and loops for the header as requested.
…e-ui into yamen-private
Fixing the server for the Rouwtaak page to ensure the header is responsive, allows switching between views
adding the style for the header
header dynamisch en server fix voor rouwtaak
… recep-private
#36 Basic stylesheet setup
#36 Minor change forgot the import
Adding the CSS for the footer in the header CSS file
minor server changes
Aanpassingen o.b.v. #64 ( Code Review )
#27 Data dynamisch maken voor Rouwtaken
Exercise CSS fixes & Responsive
JS for the header, ziet er goed uit. Nice dat je de feedback over de werking van de header hebt aangepakt.
change from render to include so data get ready from the rouwtaak page data
ik heb de reversedChat gecomment omdat ik deze waarschijnlijk nog ga gebruiken want je wilt het liefst de nieuwste berichten zien als eerst inplaats van de oudste als eerst
…able-ui into feature/Messages
#27 Exercise link on rouwtaak page
#26 Styling changes for intro
De server geeft nu alleen messages voor exercise 1, maar hij gaat dat later nog fixen.
fixing css for header so it match the css off the rouwtaak page and fixing herf to the rouwtaak
for better responsive img adding the max width
header css & link #31
Server.JS dynamisch gemaakt (#81)
adding border and img ccs #36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding js for header and adding it to the head