Skip to content

fix: Make pytest config compatible with newer pytest #5779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
antznette1 wants to merge 12 commits into
base: master
Choose a base branch
from
Open

fix: Make pytest config compatible with newer pytest #5779

antznette1 wants to merge 12 commits into from

Conversation

@antznette1
Copy link
Contributor

@antznette1 antznette1 commented Dec 16, 2025

What this PR does / why we need it:

  • Update sdk/python/pytest.ini to avoid relying on internal _pytest.warning_types.* warning classes (breaks on newer pytest).
  • Fix Windows multiprocessing start method selection (sys.platform is win32, not windows).
  • Avoid importing optional integration-only dependencies at conftest.py import time (so test collection doesn’t hard-fail when optional deps aren’t installed).

Why we need it:

  • Unblocks local test runs on newer pytest versions and improves Windows contributor experience.

Testing

  • Local: verified pytest no longer fails early due to invalid warning class / Windows fork start method.

@antznette1 antznette1 requested a review from a team as a code owner December 16, 2025 16:38
@ntkathole ntkathole changed the title fix: make pytest config compatible with newer pytest fix: Make pytest config compatible with newer pytest Dec 23, 2025
@ntkathole ntkathole force-pushed the fix/pytest-windows-test-config branch from e5ef90b to 99c742d Compare December 23, 2025 07:59
@ntkathole
Copy link
Member

ntkathole commented Dec 23, 2025

@antznette1 Can you please fix the linting ? Thanks

jyejare and others added 12 commits January 3, 2026 01:13
@jyejare @antznette1
Remaining conversion files for v1 API ver
4c96cf9 
Signed-off-by: jyejare <jyejare@redhat.com>
Signed-off-by: Anthonette Adanyin <106275232+antznette1@users.noreply.github.com>
@antznette1
Fix: Rename example_repo.py to feature_definitions.py in templates
aaca79c 
Signed-off-by: Anthonette Adanyin <106275232+antznette1@users.noreply.github.com>
@franciscojavierarceo @antznette1
feat: Add Pytorch template (feast-dev#5780)
7386c2a 
* feat: Add PyTorch NLP template with sentiment analysis and update CLI to support repo-path

* feat: Add PyTorch NLP template with sentiment analysis and update CLI to support repo-path

* fix linter

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>

---------

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Anthonette Adanyin <106275232+antznette1@users.noreply.github.com>
@antznette1 @franciscojavierarceo
docs: Add dedicated Feast on Kubernetes page (feast-dev#5781)
76c91db 
docs: add dedicated Feast on Kubernetes page

Signed-off-by: antznette1 <ochiezeanthonette@gmail.com>
Co-authored-by: Francisco Javier Arceo <arceofrancisco@gmail.com>
Signed-off-by: Anthonette Adanyin <106275232+antznette1@users.noreply.github.com>
@feast-ci-bot @antznette1
chore(release): release 0.58.0
a78a5de 
# [0.58.0](feast-dev/feast@v0.57.0...v0.58.0) (2025-12-16)

### Bug Fixes

* Add java proto ([feast-dev#5719](feast-dev#5719)) ([fc3ea20](feast-dev@fc3ea20))
* Add possibility to force full features names for materialize ops ([feast-dev#5728](feast-dev#5728)) ([55c9c36](feast-dev@55c9c36))
* Fixed file registry cache sync ([09505d4](feast-dev@09505d4))
* Handle hyphon in sqlite project name ([feast-dev#5575](feast-dev#5575)) ([feast-dev#5749](feast-dev#5749)) ([b8346ff](feast-dev@b8346ff))
* Pinned substrait to fix protobuf issue ([d0ef4da](feast-dev@d0ef4da))
* Set TLS certificate annotation only on gRPC service ([feast-dev#5715](feast-dev#5715)) ([75d13db](feast-dev@75d13db))
* SQLite online store deletes tables from other projects in shared registry scenarios ([feast-dev#5766](feast-dev#5766)) ([fabce76](feast-dev@fabce76))
* Validate not existing entity join keys for preventing panic ([0b93559](feast-dev@0b93559))

### Features

* Add annotations for pod templates ([534e647](feast-dev@534e647))
* Add Pytorch template ([feast-dev#5780](feast-dev#5780)) ([6afd353](feast-dev@6afd353))
* Add support for extra options for stream source ([feast-dev#5618](feast-dev#5618)) ([18956c2](feast-dev@18956c2))
* Added matched_tag field search api results with fuzzy search capabilities ([feast-dev#5769](feast-dev#5769)) ([4a9ffae](feast-dev@4a9ffae))
* Added support for enabling metrics in Feast Operator ([feast-dev#5317](feast-dev#5317)) ([feast-dev#5748](feast-dev#5748)) ([a8498c2](feast-dev@a8498c2))
* Configure CacheTTLSecondscache,CacheMode for file-based registry in Feast Operator([feast-dev#5708](feast-dev#5708)) ([feast-dev#5744](feast-dev#5744)) ([f25f83b](feast-dev@f25f83b))
* Implemented Tiling Support for Time-Windowed Aggregations ([feast-dev#5724](feast-dev#5724)) ([7a99166](feast-dev@7a99166))
* Offline Store historical features retrieval based on datetime range for spark ([feast-dev#5720](feast-dev#5720)) ([27ec8ec](feast-dev@27ec8ec))
* Offline Store historical features retrieval based on datetime range in dask ([feast-dev#5717](feast-dev#5717)) ([a16582a](feast-dev@a16582a))
* Production ready feast operator with v1 apiversion ([feast-dev#5771](feast-dev#5771)) ([49359c6](feast-dev@49359c6))
* Support for Map value data type ([feast-dev#5768](feast-dev#5768)) ([feast-dev#5772](feast-dev#5772)) ([b99a8a9](feast-dev@b99a8a9))

Signed-off-by: Anthonette Adanyin <106275232+antznette1@users.noreply.github.com>
@antznette1
fix: Populate Postgres registry.path during feast init (feast-dev…
7e7932e 
…#5785)

Signed-off-by: Anthonette Adanyin <106275232+antznette1@users.noreply.github.com>
@woop @antznette1
Remove Cast.ai logo from index page
c79579e 
Removed Cast.ai logo from the homepage.

Signed-off-by: Anthonette Adanyin <106275232+antznette1@users.noreply.github.com>
@Srihari1192 @antznette1
Add Workbecnh Ray Compute engine and offline store test
1e62700 
Signed-off-by: Srihari <svenkata@redhat.com>
Signed-off-by: Anthonette Adanyin <106275232+antznette1@users.noreply.github.com>
@franciscojavierarceo @antznette1
feat: Enable static artifacts for feature server that can be used in …
be0d859 
…Feature Transformations (feast-dev#5787)

* feat: Enable static artifacts for feature server that can be used in Feature Transformations

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>

* feat: Enable static artifacts for feature server that can be used in Feature Transformations

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>

* feat: Enable static artifacts for feature server that can be used in Feature Transformations

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>

* updated docs

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>

* adding docs

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>

* update

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>

---------

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Anthonette Adanyin <106275232+antznette1@users.noreply.github.com>
@astronautas @antznette1
fix: Add possibility to overwrite send_receive_timeout for clickhouse…
7dd2dd4 
… offline store (feast-dev#5792)

* add changes + fix linting issues

Signed-off-by: lukas.valatka <lukas.valatka@cast.ai>

* generalize based on pr suggestion

Signed-off-by: lukas.valatka <lukas.valatka@cast.ai>

* add test verifying config parsing

Signed-off-by: lukas.valatka <lukas.valatka@cast.ai>

* rework test into integration, since CH instance is needed

Signed-off-by: lukas.valatka <lukas.valatka@cast.ai>

---------

Signed-off-by: lukas.valatka <lukas.valatka@cast.ai>
Signed-off-by: Anthonette Adanyin <106275232+antznette1@users.noreply.github.com>
@antznette1
fix: make pytest config compatible with newer pytest
4f9b1d0 
Signed-off-by: amiraifori <iforiamira@gmail.com>
Signed-off-by: antznette1 <ochiezeanthonette@gmail.com>
Signed-off-by: Anthonette Adanyin <106275232+antznette1@users.noreply.github.com>
@antznette1
Update conftest.py
1835d0f 
Signed-off-by: Anthonette Adanyin <106275232+antznette1@users.noreply.github.com>
@antznette1 antznette1 force-pushed the fix/pytest-windows-test-config branch from 081c356 to 1835d0f Compare January 3, 2026 01:13
@antznette1
Copy link
Contributor Author

antznette1 commented Jan 3, 2026

@antznette1 Can you please fix the linting ? Thanks

@ntkathole

I have done it.

@franciscojavierarceo
Copy link
Member

franciscojavierarceo commented Jan 3, 2026

@antznette1 looks like you need to resolve conflicts please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@antznette1 @ntkathole @franciscojavierarceo @jyejare @feast-ci-bot @woop @Srihari1192 @astronautas