-
-
Notifications
You must be signed in to change notification settings - Fork 333
Add GeoDistanceTransformer for geographic distance calculation #881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ankitlade12
wants to merge
23
commits into
feature-engine:main
Choose a base branch
from
ankitlade12:add-geodistance-transformer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add GeoDistanceTransformer for geographic distance calculation #881
ankitlade12
wants to merge
23
commits into
feature-engine:main
from
ankitlade12:add-geodistance-transformer
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitlade12
commented
Jan 8, 2026
- Add GeoDistanceTransformer class for calculating distances between coordinate pairs
- Support haversine, euclidean, and manhattan distance methods
- Support km, miles, meters, and feet output units
- Add validate_ranges parameter to skip coordinate validation
- Add comprehensive tests with pytest parametrize
- Add user guide and API documentation
- Add pipeline test to test_check_estimator_creation.py
- Add GeoDistanceTransformer class for calculating distances between coordinate pairs - Support haversine, euclidean, and manhattan distance methods - Support km, miles, meters, and feet output units - Add validate_ranges parameter to skip coordinate validation - Add comprehensive tests with pytest parametrize - Add user guide and API documentation - Add pipeline test to test_check_estimator_creation.py
- Add GeoDistanceTransformer class for calculating distances between coordinate pairs - Support haversine, euclidean, and manhattan distance methods - Support km, miles, meters, and feet output units - Add validate_ranges parameter to skip coordinate validation - Add comprehensive tests with pytest parametrize - Add user guide and API documentation - Add pipeline test to test_check_estimator_creation.py
Collaborator
|
FYI |
…ine and resolve rename conflicts
solegalli
reviewed
Jan 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #881 +/- ##
==========================================
+ Coverage 98.07% 98.11% +0.04%
==========================================
Files 112 113 +1
Lines 4722 4829 +107
Branches 752 768 +16
==========================================
+ Hits 4631 4738 +107
Misses 56 56
Partials 35 35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…tlade12/feature_engine into add-geodistance-transformer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.