Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fintoc/managers/v2/accounts_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class AccountsManager(ManagerMixin):
"""Represents an accounts manager."""

resource = "account"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Severity: medium 🟠
Duplicate addition of 'update' method in AccountsManager methods list across commits.

methods = ["list", "get", "create"]
methods = ["list", "get", "create", "update"]

def __init__(self, path, client):
super().__init__(path, client)
Expand Down
2 changes: 1 addition & 1 deletion fintoc/version.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
"""Module to hold the version utilities."""

version_info = (2, 12, 0)
version_info = (2, 13, 0)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Severity: low 🟡
Duplicate version bump in version_info across commits.

__version__ = ".".join([str(x) for x in version_info])
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "fintoc"
version = "2.12.0"
version = "2.13.0"
description = "The official Python client for the Fintoc API."
authors = ["Daniel Leal <daniel@fintoc.com>", "Nebil Kawas <nebil@uc.cl>"]
maintainers = ["Daniel Leal <daniel@fintoc.com>"]
Expand Down
11 changes: 11 additions & 0 deletions tests/test_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -561,6 +561,17 @@ def test_v2_account_create(self):
assert account.url == "v2/accounts"
assert account.json.description == account_data["description"]

def test_v2_account_update(self):
"""Test updating an account using v2 API."""
account_id = "test_account_id"
update_data = {"description": "Updated test account"}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Severity: medium 🟠
Duplicate definition of test_v2_account_update in integration tests.


account = self.fintoc.v2.accounts.update(account_id, **update_data)

assert account.method == "patch"
assert account.url == f"v2/accounts/{account_id}"
assert account.json.description == update_data["description"]

def test_v2_account_numbers_list(self):
"""Test getting all account numbers using v2 API."""
account_id = "test_account_id"
Expand Down