[PAY-3366] Feat add payment links and check elegibility endpoint #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamunozcar
force-pushed
the
feat-add-payment-links-and-check-elegibility-endpoint
branch
2 times, most recently
from
0373dd5 to
7fb43e0
Compare
mamunozcar
force-pushed
the
feat-add-payment-links-and-check-elegibility-endpoint
branch
from
7fb43e0 to
64187c6
Compare
| from fintoc.mixins import ResourceMixin | ||
|
|
||
|
|
||
| class PaymentLink(ResourceMixin): |
Contributor
Author
There was a problem hiding this comment.
Yes, esto es necesario bajo la arquitectura que se siguió para armar el sdk. Dejo una pequeña explicación de esta:
Ocurre que esta clase al final termina siendo el tipo de objeto con el que responde la api cuando por ejemplo se hace un client.payment_links, en donde esto respondería un objeto del tipo PaymentLink. Esto ocurre gracias a que nosotros dentro de PaymentLinksManager (fintoc/managers/payment_links_manager.py) definimos cual es el resource y con esto define el objeto que antes mencionaba.
Este proceso es seguido por todos los recursos creados dentro de este sdk por lo que estuve revisando al hacer la implementación
There was a problem hiding this comment.
aaaaa buenisimo! gracias por explicarr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add the resource
PaymentLinkwith its corresponding manager.Also, it adds the
check-elegibilityendpoint for thePaymentIntentsresourceDejo la documentación de ambos puntos:
Requirements
None.
Additional changes
It was necessary to modify the resource_update, because it did not allow custom routes, it only allowed routes with the defined ID.