Feature/shrink boost dependency #218
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdobad
force-pushed
the
feature/shrink-boost-dependency
branch
from
db9d2dd to
fc43513
Compare
fdobad
force-pushed
the
feature/shrink-boost-dependency
branch
from
fc43513 to
214621f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boost is a heavy library.
boost:algorithm was only used to split csv rows into strings, hence replaced with a simple function
boost:random is tested to be cross platform consistent, meanwhile std.random is not, hence cannot be replaced until the workflow passes!
So now the code doesn't depend on boost-all but boost-random!