Implementation of Cloud Storage function.#286
Closed
kiliczsh wants to merge 5 commits intofirebase:masterfrom
kiliczsh:master
Closed
Implementation of Cloud Storage function.#286kiliczsh wants to merge 5 commits intofirebase:masterfrom kiliczsh:master
kiliczsh wants to merge 5 commits intofirebase:masterfrom
kiliczsh:master
Conversation
Contributor
|
Thanks @kiliczsh for the PR (complete with integration tests). Storage support in .NET has always been a bit of a conundrum. In all other languages of the Admin SDK, we expose the "bucket" as the primary abstraction. For example in Node.js: const admin = require('firebase-admin');
admin.initializeApp({
storageBucket: 'example.bucket.name',
});
const bucket = admin.storage().bucket();But as you already know, in the .NET Storage client, that abstraction does not exist. This results in a very different developer experience. I'd like to run this by our internal API review team, and see what they think about it. Since we have no way of passing a bucket name to the Storage client via Firebase app options, I'm not certain if this integration adds a lot of value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: #72 #71
Configuration keys are missing on the actions machines so that had to handle exceptions.
Google was not allowing me to submit other users commits so that had to copy all, sorry @takuya1981.
@googlebot I consent.
All credits to @takuya1981 .