feat(firestore): Added Firestore Multi Database Support

[jonathanedey]

RELEASE NOTE: Added support for multiple Cloud Firestore named databases.

[gemini-code-assist]

Summary of Changes

Hello @jonathanedey, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Firestore client by introducing support for multiple named databases. It provides a new API method, FirestoreWithDatabase, allowing developers to specify a target database when initializing a Firestore client. This change is accompanied by thorough unit and integration tests to ensure the reliability and correct behavior of the new multi-database capabilities, facilitating more flexible and scalable Firestore interactions.

Highlights

• Multi-Database Support: Introduced a new FirestoreWithDatabase method to the App struct, enabling the creation of firestore.Client instances for specific named Cloud Firestore databases.
• Enhanced Testing: Added comprehensive unit tests for the new FirestoreWithDatabase function, covering successful client creation and error handling for missing project IDs. New integration tests were also added to validate multi-database functionality, including concurrent operations on different databases.
• Integration Test Refinements: Updated existing integration tests to utilize new test data structures and improved the TestServerTimestamp to correctly verify the type of server-generated timestamps.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for multiple Cloud Firestore databases by adding a new FirestoreWithDatabase function. The implementation is accompanied by comprehensive unit and integration tests. My feedback focuses on improving code maintainability by addressing code duplication and enhancing the robustness of the integration tests to ensure proper resource cleanup.

[jonathanedey]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces support for multiple named databases in Cloud Firestore by adding a FirestoreWithDatabase method. The implementation maintains backward compatibility by having the existing Firestore method call the new one with the default database ID. The changes are well-tested with new unit and integration tests. My review includes a couple of suggestions for the new integration tests to improve maintainability and adhere to Go's testing best practices.

[lahirumaramba]

Thank you! Added a few comments.

[lahirumaramba]

This feels repetitive. Doesn't TestFirestoreWithDatabaseID and TestFirestore cover this?

[jonathanedey]

This test in for verifying that two databases clients can be opened and modified at once with no impact on the other.

[lahirumaramba]

Okay. We can keep this, but as a clarification, to me this feels like we are trying to test the cloud firestore SDK here. This should be a more fitting test for the Firestore SDK and slightly beyond the Admin SDK scope. The Admin SDK should test the part where we are setting the database ID in the Firestore SDK and everything beyond that should be tested in the Firestore SDK itself (which I think they do).

[lahirumaramba]

Thanks! LGTM!
We should be good once we get a TW review.

[lahirumaramba]

Okay. We can keep this, but as a clarification, to me this feels like we are trying to test the cloud firestore SDK here. This should be a more fitting test for the Firestore SDK and slightly beyond the Admin SDK scope. The Admin SDK should test the part where we are setting the database ID in the Firestore SDK and everything beyond that should be tested in the Firestore SDK itself (which I think they do).