-
Notifications
You must be signed in to change notification settings - Fork 666
[Firestore] Update setup instructions #7659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly improves the clarity and accuracy of the Firestore setup instructions. The refactoring of the README makes it much more organized and easier for developers to follow. Documenting the previously hidden CLI flags is also a very helpful addition. I've identified a couple of minor opportunities for improvement and one important inconsistency regarding the google-services.json file path that should be addressed to avoid confusion.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Refactors Firestore README to fix setup inaccuracies I found when setting up my local dev environment and improves the documentation for running integration tests.
google-services.jsonpath: The previous instruction for placinggoogle-services.jsonat the root dir was incorrect, and caused the tests to fallback to using a dummy config, which caused my tests to fail. After moving the file tofirebase-firestore/google-services.jsonthe tests passed for me.-PtargetBackend,-PbackendEdition,-PtargetDatabaseId)