Skip to content

Conversation

@rlazo
Copy link
Collaborator

@rlazo rlazo commented Jan 29, 2026

Instead of finishing the session when the go away message is received, keeping it open leaves more room for developers to implement different strategies in their callback method. Additionally, it preserves the current behaviour.

Instead of finishing the session when the go away message is received, keeping it open leaves more room for developers to implement different strategies in their callback method. Additionally, it preserves the current behaviour.
@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2026

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Collaborator

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Collaborator

The public api surface has changed for the subproject firebase-ai:
error: Added method com.google.firebase.ai.type.LiveAudioConversationConfig.Builder.setGoAwayHandler(kotlin.jvm.functions.Function1<? super com.google.firebase.ai.type.LiveServerGoAway,kotlin.Unit>) [AddedMethod]
error: Added field com.google.firebase.ai.type.LiveAudioConversationConfig.Builder.goAwayHandler [AddedField]
error: Added class com.google.firebase.ai.type.LiveServerGoAway [AddedClass]
error: Removed method com.google.firebase.ai.type.LiveSession.startAudioConversation(kotlin.jvm.functions.Function1<? super com.google.firebase.ai.type.FunctionCallPart,com.google.firebase.ai.type.FunctionResponsePart>,kotlin.jvm.functions.Function2<? super com.google.firebase.ai.type.Transcription,? super com.google.firebase.ai.type.Transcription,kotlin.Unit>,boolean,kotlin.coroutines.Continuation<? super kotlin.Unit>) [RemovedMethod]
error: Added method com.google.firebase.ai.type.LiveSession.startAudioConversation(kotlin.jvm.functions.Function1<? super com.google.firebase.ai.type.FunctionCallPart,com.google.firebase.ai.type.FunctionResponsePart>,kotlin.jvm.functions.Function2<? super com.google.firebase.ai.type.Transcription,? super com.google.firebase.ai.type.Transcription,kotlin.Unit>,kotlin.jvm.functions.Function1<? super com.google.firebase.ai.type.LiveServerGoAway,kotlin.Unit>,boolean,kotlin.coroutines.Continuation<? super kotlin.Unit>) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@rlazo rlazo enabled auto-merge (squash) January 29, 2026 20:30
@rlazo rlazo merged commit 976a718 into main Jan 29, 2026
31 checks passed
@rlazo rlazo deleted the rl.goaway.noclose branch January 29, 2026 20:50
rlazo added a commit that referenced this pull request Jan 30, 2026
Instead of finishing the session when the go away message is received,
keeping it open leaves more room for developers to implement different
strategies in their callback method. Additionally, it preserves the
current behaviour.
rlazo added a commit that referenced this pull request Jan 30, 2026
Instead of finishing the session when the go away message is received,
keeping it open leaves more room for developers to implement different
strategies in their callback method. Additionally, it preserves the
current behaviour.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants