-
Notifications
You must be signed in to change notification settings - Fork 666
[AI] Don't end connection early when receiving GoAway #7688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Instead of finishing the session when the go away message is received, keeping it open leaves more room for developers to implement different strategies in their callback method. Additionally, it preserves the current behaviour.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Generated by 🚫 Danger |
|
The public api surface has changed for the subproject firebase-ai: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
Instead of finishing the session when the go away message is received, keeping it open leaves more room for developers to implement different strategies in their callback method. Additionally, it preserves the current behaviour.
Instead of finishing the session when the go away message is received, keeping it open leaves more room for developers to implement different strategies in their callback method. Additionally, it preserves the current behaviour.
Instead of finishing the session when the go away message is received, keeping it open leaves more room for developers to implement different strategies in their callback method. Additionally, it preserves the current behaviour.