Closed
Conversation
This commit removes the deprecated GMA C++ SDK from the project. The following changes were made: - Renamed the directory to . - Removed from . - Removed GMA-related entries from . - Removed from the array in build path: ios_build source path: . build platforms: device simulator build architectures: arm64 x86_64 build targets: firebase_analytics firebase_auth firebase_app_check firebase_database firebase_dynamic_links firebase_firestore firebase_functions firebase_installations firebase_messaging firebase_remote_config firebase_storage generate Makefiles: true CMake Build: true generate Makefiles start. - Partially updated to remove GMA from the default apis list. - Partially updated to remove logic related to gma_flag. - Removed the "Google Mobile Ads" entry from the feature table for Android dependencies in . - Removed the "Google Mobile Ads (stub) | firebase_gma.lib" line from the Desktop Implementations table in . Note: Some changes in , and might not be fully applied due to issues with the tool. Tests were skipped due to a tool error.
This change removes the Google Mobile Ads (GMA) C++ SDK, which has been deprecated. Modifications include: - Deletion of the 'gma' directory. - Removal of GMA references from CMakeLists, Gradle files, and other build scripts across all platforms (Android, iOS, Desktop). - Updates to workflow configurations and helper scripts to exclude GMA. - Adjustments to documentation (readme.md) to reflect the removal of GMA, while preserving its mention in historical release notes.
jonsimantov
added
the
tests-requested: full
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the deprecated GMA C++ SDK
Testing
Integration tests and packaging running on this PR.
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.