feat(go): add NewFlow and NewStreamingFlow
#4380
Conversation
Summary of ChangesHello @apascal07, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces new functions, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces NewFlow and NewStreamingFlow functions to separate the creation of flows from their registration. This is a positive architectural change that improves the API's clarity and flexibility. The existing DefineFlow and DefineStreamingFlow functions have been refactored to use these new creator functions, which is a clean implementation. The changes are also correctly exposed through the genkit package. My review includes suggestions to add nil-checks for the function arguments in the new flow creation functions to improve robustness and provide clearer error messages on invalid usage.
| func NewStreamingFlow[In, Out, Stream any](name string, fn StreamingFunc[In, Out, Stream]) *Flow[In, Out, Stream] { | ||
| return (*Flow[In, Out, Stream])(NewStreamingAction(name, api.ActionTypeFlow, nil, nil, func(ctx context.Context, input In, cb func(context.Context, Stream) error) (Out, error) { | ||
| fc := &flowContext{ | ||
| flowName: name, | ||
| } | ||
| ctx = flowContextKey.NewContext(ctx, fc) | ||
| if cb == nil { | ||
| cb = func(context.Context, Stream) error { return nil } | ||
| } | ||
| return fn(ctx, input, cb) | ||
| })) | ||
| } |
There was a problem hiding this comment.
Similar to NewFlow, we should add a nil check for the fn argument in NewStreamingFlow. This ensures that we fail early with a descriptive error message if a nil function is provided, preventing a runtime panic that is harder to trace.
func NewStreamingFlow[In, Out, Stream any](name string, fn StreamingFunc[In, Out, Stream]) *Flow[In, Out, Stream] {
if fn == nil {
panic("core.NewStreamingFlow: fn cannot be nil")
}
return (*Flow[In, Out, Stream])(NewStreamingAction(name, api.ActionTypeFlow, nil, nil, func(ctx context.Context, input In, cb func(context.Context, Stream) error) (Out, error) {
fc := &flowContext{
flowName: name,
}
ctx = flowContextKey.NewContext(ctx, fc)
if cb == nil {
cb = func(context.Context, Stream) error { return nil }
}
return fn(ctx, input, cb)
}))
}
2 participants
Checklist (if applicable):