revert: dap

[yesudeep]

Revert DAP.

[gemini-code-assist]

Summary of Changes

Hello @yesudeep, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request effectively reverts the recent integration of the Dynamic Action Provider (DAP) feature within the Python SDK. The changes span across core framework components, documentation, and sample applications, systematically removing the DAP implementation and its associated artifacts. This action streamlines the codebase by eliminating a feature that was likely deemed premature or problematic, ensuring a cleaner and more focused development path for the Python SDK.

Highlights

• Revert of Dynamic Action Provider (DAP) Integration: The primary change is the complete removal of the Dynamic Action Provider (DAP) feature and its integration from the Python SDK. This includes core implementation, registry integration, and associated documentation and samples.
• Removal of dap-demo Sample: The entire py/samples/dap-demo directory, including its README.md, pyproject.toml, run.sh, and src/dap_demo/__init__.py files, has been deleted.
• Documentation Updates: The py/GEMINI.md file has been cleaned up, removing blank lines and a substantial section detailing DAP best practices, ASGI types, and sample structure. The py/engdoc/parity-analysis/roadmap.md has also been updated to remove DAP-related milestones and tasks.
• Core Code Refactoring: Significant changes were made in py/packages/genkit/src/genkit/blocks/dap.py and py/packages/genkit/src/genkit/core/registry.py to remove DAP-specific classes, functions, and logic, such as SimpleCache modifications, removal of _create_action_metadata, transform_dap_value adjustments, and the removal of DynamicActionProviderProtocol, ParsedRegistryKey, parse_registry_key, resolve_action_names, lookup_action_by_key, and list_resolvable_actions.
• Test Suite Adjustments: The py/packages/genkit/tests/genkit/blocks/dap_test.py file has been updated to remove tests related to the reverted DAP functionality and adjust existing tests to reflect the new (or absent) DAP behavior.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• py/GEMINI.md
  • Removed blank lines from code examples.
  • Removed a large section on "Session Learnings: DAP, ASGI Types, and Sample Structure".
• py/engdoc/parity-analysis/roadmap.md
  • Updated "Current Status" date.
  • Removed DAP-related entries from "Remaining Work" and "M11: Dynamic Action Provider (DAP) Analysis" sections.
• py/packages/genkit/src/genkit/blocks/dap.py
  • Removed reference to py/samples/dap-demo from docstring.
  • Refactored SimpleCache initialization and fetch logic.
  • Removed _create_action_metadata function.
  • Modified transform_dap_value to return DapMetadata dict.
  • Refactored DynamicActionProvider constructor and action logic.
• py/packages/genkit/src/genkit/core/action/init.py
  • Removed is_action_type from __all__.
• py/packages/genkit/src/genkit/core/action/types.py
  • Removed is_action_type function.
• py/packages/genkit/src/genkit/core/registry.py
  • Removed Protocol import.
  • Removed is_action_type import.
  • Removed _is_dap_action function.
  • Removed DynamicActionProviderProtocol class.
  • Removed ParsedRegistryKey class and parse_registry_key function.
  • Removed resolve_action_names and lookup_action_by_key methods.
  • Removed list_resolvable_actions method.
• py/packages/genkit/tests/genkit/blocks/dap_test.py
  • Removed imports for GenkitError and parse_registry_key.
  • Updated assertions for list_action_metadata and get_action_metadata_record tests.
  • Changed expected error type in test_handles_fetch_errors.
  • Updated test_transform_dap_value assertions.
  • Removed tests: test_parse_registry_key_standard_format, test_parse_registry_key_dap_format, test_list_resolvable_actions_includes_dap, test_runs_action_with_transformed_metadata, test_skips_trace_when_requested.
• py/pyproject.toml
  • Removed dap-demo from optional dependencies.
• py/samples/dap-demo/README.md
  • File removed.
• py/samples/dap-demo/pyproject.toml
  • File removed.
• py/samples/dap-demo/run.sh
  • File removed.
• py/samples/dap-demo/src/dap_demo/init.py
  • File removed.

Activity

• The author yesudeep initiated this pull request.
• This pull request is a revert of a previous feature implementation, specifically the "feat(py/genkit): complete DAP integration with registry (feat(py/genkit): complete DAP integration with registry #4459)".
• The changes involve extensive removal of code, documentation, and samples related to the Dynamic Action Provider (DAP) feature in the Python SDK.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request reverts a significant number of changes related to the Dynamic Action Provider (DAP) feature, effectively undoing its recent integration with the action registry. The changes span core logic, tests, documentation, and the removal of a related sample. While the revert seems consistent across most files, I've identified a critical issue where the DAP fallback mechanism is left in a broken state, which will cause runtime errors. Additionally, there's a minor formatting issue in a documentation code block. A more detailed explanation for such a large-scale revert in the pull request description would be beneficial for context and future maintenance.