Skip to content

Comments

replace forbidden mdl links with cdnjs#949

Merged
hsubox76 merged 1 commit intofirebase:masterfrom
grushabshah:master
Feb 24, 2026
Merged

replace forbidden mdl links with cdnjs#949
hsubox76 merged 1 commit intofirebase:masterfrom
grushabshah:master

Conversation

@grushabshah
Copy link
Contributor

All of mdl links return 403 forbidden causing rendering issues in the quickstart pages.

This PR is basically a recursive sed -i 's|code.getmdl.io|cdnjs.cloudflare.com/ajax/libs/material-design-lite|g;' to replace all getmdl.io links with cdnjs alternative links.

@gemini-code-assist
Copy link

Summary of Changes

Hello @grushabshah, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where the Material Design Lite (MDL) links were returning a 403 forbidden error, leading to rendering problems in the quickstart pages. To resolve this, all instances of the problematic code.getmdl.io links have been replaced with the equivalent links from cdnjs. This ensures that the quickstart pages render correctly by utilizing a reliable CDN for MDL resources.

Highlights

  • MDL Link Replacement: This PR replaces all instances of code.getmdl.io links with cdnjs.cloudflare.com/ajax/libs/material-design-lite links due to rendering issues caused by forbidden MDL links.
  • Recursive Sed Command: The changes were implemented using a recursive sed -i command to replace the outdated links across all relevant files.
  • Quickstart Pages Fix: The primary goal is to resolve rendering problems specifically affecting the quickstart pages.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • auth/anon.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/apple-popup.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/apple-redirect.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/customauth.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/email-link.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/email-password.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/exampletokengenerator/auth.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/facebook-credentials.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/facebook-popup.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/facebook-redirect.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/github-popup.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/github-redirect.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/google-credentials.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/google-popup.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/google-redirect.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/index.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/mfa-password.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/microsoft-popup.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/microsoft-redirect.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/multi-tenant-ui.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/phone-invisible.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/phone-simple-popup.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/phone-simple.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/phone-visible.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/twitter-popup.html
    • Replaced the forbidden MDL links with cdnjs links.
  • auth/twitter-redirect.html
    • Replaced the forbidden MDL links with cdnjs links.
  • database/index.html
    • Replaced the forbidden MDL links with cdnjs links.
  • functions/public/index.html
    • Replaced the forbidden MDL links with cdnjs links.
  • messaging/index.html
    • Replaced the forbidden MDL links with cdnjs links.
  • remote-config/index.html
    • Replaced the forbidden MDL links with cdnjs links.
  • storage/index.html
    • Replaced the forbidden MDL links with cdnjs links.
Activity
  • The pull request replaces the code.getmdl.io links with cdnjs.cloudflare.com/ajax/libs/material-design-lite links.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully updates all code.getmdl.io links to cdnjs.cloudflare.com/ajax/libs/material-design-lite across multiple HTML files. This change addresses the 403 forbidden errors and rendering issues, improving the reliability of the quickstart pages. The changes are consistent and directly resolve the stated problem.

@hsubox76 hsubox76 merged commit 96f1905 into firebase:master Feb 24, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants