Enhance cross-version support#23
Open
wllenyj wants to merge 1 commit intofirecracker-microvm:mainfrom
Open
Conversation
In production use, we usually have multiple release branches, each branch corresponding to a minor version. When we develop between versions, there may be changes to fields of struct. This brings a lot of complexity and maintenance cost to version control. Signed-off-by: wanglei01 <wllenyj@linux.alibaba.com>
6 tasks
wllenyj
added a commit
to wllenyj/dragonball-sandbox
that referenced
this pull request
May 21, 2023
Since our PR (firecracker-microvm/versionize_derive#23) can't be merged into upstream for a short time, here we fork it first. After the upstream is merged, switch to the upstream dependency. Signed-off-by: wllenyj <wllenyj@linux.alibaba.com>
wllenyj
added a commit
to wllenyj/dragonball-sandbox
that referenced
this pull request
May 21, 2023
fork https://github.com/firecracker-microvm/versionize_derive.git Since our PR (firecracker-microvm/versionize_derive#23) can't be merged into upstream for a short time, here we fork it first. After the upstream is merged, switch to the upstream dependency. Signed-off-by: wllenyj <wllenyj@linux.alibaba.com>
wllenyj
added a commit
to wllenyj/dragonball-sandbox
that referenced
this pull request
May 24, 2023
fork https://github.com/firecracker-microvm/versionize_derive.git Since our PR (firecracker-microvm/versionize_derive#23) can't be merged into upstream for a short time, here we fork it first. After the upstream is merged, switch to the upstream dependency. Signed-off-by: wllenyj <wllenyj@linux.alibaba.com>
wllenyj
added a commit
to wllenyj/dragonball-sandbox
that referenced
this pull request
May 29, 2023
Since our PR (firecracker-microvm/versionize_derive#23) can't be merged into upstream for a short time, here we fork it first. After the upstream is merged, switch to the upstream dependency. Signed-off-by: wllenyj <wllenyj@linux.alibaba.com>
wllenyj
added a commit
to wllenyj/dragonball-sandbox
that referenced
this pull request
May 29, 2023
fork https://github.com/firecracker-microvm/versionize_derive.git Since our PR (firecracker-microvm/versionize_derive#23) can't be merged into upstream for a short time, here we fork it first. After the upstream is merged, switch to the upstream dependency. Signed-off-by: wllenyj <wllenyj@linux.alibaba.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for This PR
In production use, we usually have multiple release branches, each branch corresponding to a minor version. When we develop between versions, there may be changes to fields of struct. This brings a lot of complexity and maintenance cost to version control.
Description of Changes
Now writing a Versionize derive for a structure can look like this.
or enum:
Advantages:
The code generated by the above example:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).unsafecode is properly documented.CHANGELOG.md.