refactor: template steps #813
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dieppa
reviewed
Jan 29, 2026
| private Object configuration; | ||
| private Object apply; | ||
| private Object rollback; | ||
| private Object steps; |
Member
There was a problem hiding this comment.
Cannot make this at least a generic list List? Ideally a List<TemplateStep>
dieppa
reviewed
Jan 29, 2026
Comment on lines
+147
to
+150
| if (!(stepsData instanceof List)) { | ||
| logger.warn("Steps data is not a List, ignoring"); | ||
| return result; | ||
| } |
Member
There was a problem hiding this comment.
We shouldn't ignore the list as it's mandatory, right?
dieppa
requested changes
Jan 29, 2026
Member
dieppa
left a comment
dieppa
left a comment
There was a problem hiding this comment.
Still haven't reflected the list in the builders.
Also we are treating like optional, when it's mandatory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: template steps