Skip to content

Conversation

@Robbendebiene
Copy link
Contributor

This PR allows setting a separate FilterQuality (and more importantly null) on the Transform widget instead of using the same filterQuality as used on the Image for RotatedOverlayImage. I believe this was an oversight introduced by this change: 2e64369

This fixes a problem we encountered. When zooming the rotated image sometimes flickers. My guess is that this happens because the rotated image is raster cached (due to filterQuality not being null see: flutter/flutter#106006 (comment)) and when the raster cache gets full (due to tiles coming in) the rotated image is somehow purged from the cache.

Demo of the bug:

FlickeringImage.mp4

@JaffaKetchup JaffaKetchup requested a review from a team December 21, 2025 15:30
@JaffaKetchup JaffaKetchup changed the title Add separate FilterQuality parameter to RotatedOverlayImage featl/ Add separate FilterQuality parameter to RotatedOverlayImage Dec 21, 2025
@JaffaKetchup JaffaKetchup changed the title featl/ Add separate FilterQuality parameter to RotatedOverlayImage feat: add separate RotatedOverlayImage.transformFilterQuality parameter Dec 21, 2025
…tch existing behaviour

Improve documentation
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Robbendebiene, thanks for the PR.

To reduce the amount that this change is technically breaking, I've changed the default transformFilterQuality to match the existing default filterQuality of FilterQuality.medium (rather than null). This is technically still breaking for user's that have overridden filterQuality, but we've allowed small behaviour changes like this in the past without categorising them as breaking.

@JaffaKetchup JaffaKetchup requested a review from a team December 21, 2025 15:49
@JaffaKetchup
Copy link
Member

I'd also appreciate another review from another @fleaflet/maintainers :)

@Robbendebiene
Copy link
Contributor Author

To reduce the amount that this change is technically breaking, I've changed the default transformFilterQuality to match the existing default filterQuality of FilterQuality.medium (rather than null). This is technically still breaking for user's that have overridden filterQuality, but we've allowed small behaviour changes like this in the past without categorising them as breaking.

Fine by me 👍

I believe null is the better default option for the future. Is it possible to add a doc comment or reminder for the next major release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants