Skip to content

Comments

[Hotfix Main]: Added result model for ForceOutput#1768

Merged
piotrkluba merged 1 commit intomainfrom
hotfix-main-pr1752
Feb 4, 2026
Merged

[Hotfix Main]: Added result model for ForceOutput#1768
piotrkluba merged 1 commit intomainfrom
hotfix-main-pr1752

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 4, 2026

Hotfix of PR #1752 (#1752) to the main branch.
Hey @piotrkluba, please review this hotfix PR created from your original PR.


Note

Medium Risk
Touches core results discovery/download plumbing and adds new file-pattern based behavior, which could affect what gets downloaded for cases depending on their params and available files.

Overview
Adds first-class support for ForceOutput-generated CSVs as a case result.

CaseResultsModel now exposes custom_forces backed by a new CustomForceResultModel that discovers result files matching force_output_(.+)_v2.csv, supports name-based access ([]/get_custom_force_by_name), and is wired into CaseResultsModel.download() and _is_downloadable via Case.has_custom_forces()/SimulationParams.has_custom_forces().

Also refactors monitor/UDD discovery into private _populate_* helpers, and extends tests + mock fixture data with force output CSVs and coverage for discovery, downloading hooks, and CSV loading.

Written by Cursor Bugbot for commit ad0b8a1. This will update automatically on new commits. Configure here.

@piotrkluba piotrkluba marked this pull request as ready for review February 4, 2026 15:15
@piotrkluba piotrkluba merged commit 9438953 into main Feb 4, 2026
19 checks passed
@piotrkluba piotrkluba deleted the hotfix-main-pr1752 branch February 4, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant