Fixed an issue where Flight::request()->base would display only a yen symbol in Windows environments without a parent directory#666
Conversation
|
Hey there! Thanks for contributing! I ran the workflows and it looks like all of them are failing the PHP Unit tests. The thing for you to check is when you're testing this to make sure it works locally. You can test it with The thing I'm wondering about is more why you have slash characters being converted to Yen characters. Part of me is wondering if you have a weird version of PHP or something? I've never heard of that before and I've used/built things with Flight on Windows before without the issues you were talking about. |
…en symbol in Windows environments without a parent directory.
11b7ae1 to
40f176f
Compare
Flight::request()->base would display only a yen symbol in Windows environments without a parent directory
|
Hello. I apologize for the inconvenience caused by my oversight. I have updated the pull request title and comments; I would appreciate it if you could review them. |
n0nag0n
left a comment
There was a problem hiding this comment.
That is odd behavior for sure. It looks safe how you've implemented it and all unit tests are passing now so I think we're good to merge this in, thanks!
In Windows environments, when
$_SERVER['SCRIPT_NAME']is a filename without a parent directory, such as/index.php,Flight::request()->basereturns only a yen symbol. This issue will be fixed.* As this is my first pull request to this repository, I would appreciate it if you could point out any issues.