fix index_root or app_root not set in .runway-config.json error#672
Closed
ycrao wants to merge 5 commits intoflightphp:masterfrom
Closed
fix index_root or app_root not set in .runway-config.json error#672ycrao wants to merge 5 commits intoflightphp:masterfrom
ycrao wants to merge 5 commits intoflightphp:masterfrom
Conversation
Contributor
Author
Collaborator
|
Hey there, thanks for doing this, although I had to do a lot more to it. I needed to still accept the old .runway-config.json file if it was still there and accept the config.php values so it took more refactoring. #673 Thanks for contributing lately! Hop in the discord channel and say hi if you haven't already! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
app_rootandindex_rootvalues are now located in$config['runway'].