Add config to disable the Fully Enable button#973
Open
elShiaLabeouf wants to merge 1 commit intoflippercloud:mainfrom
Open
Add config to disable the Fully Enable button#973elShiaLabeouf wants to merge 1 commit intoflippercloud:mainfrom
elShiaLabeouf wants to merge 1 commit intoflippercloud:mainfrom
Conversation
Collaborator
|
I'm not sure I understand why. Why would you not eventually fully enable a feature? |
Author
|
Hey @jnunemaker, thanks for the quick response! :) Our project is actively developing, the feature set is expanding, the design is changing; and while most of the users are happy with such active support, a small percentage of them would prefer to keep the product minimalistic. I would very much like to fulfill their wishes since it's easy - we'll just leverage a Flipper group "everyone except these guys". At the same time, I want to minimize the chance of someone accidentally fully enabling a FF for everyone - that's where disabling the button would come in handy. Please share your thoughts on the proposal! Maybe there's a better way to achieve this goal? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I'm proposing to add two new configuration options for
Flipper::UIto allow disabling theFully Enablebutton.Use case
When rolling out features gradually (i.e. test group first, then wider), there are cases where fully enabling for everyone isn't appropriate - for example, when certain users have opted out of receiving new features. This configuration prevents accidental full rollouts.
Demo
Default behavior (

config.fully_enable_disabledisfalseby default):Disabled button & default tooltip:
Disabled button & custom tooltip: