Skip to content

Feature/piecewise #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
FBumann wants to merge 1 commit into from
Closed

Feature/piecewise #206

FBumann wants to merge 1 commit into from

Conversation

@FBumann
Copy link
Member

@FBumann FBumann commented Mar 29, 2025 •
edited
Loading

Remove feature PieceModel, Further simplifying the code

@FBumann FBumann changed the base branch from main to next/major March 29, 2025 14:42
@FBumann FBumann requested a review from baumbude March 29, 2025 16:36
@FBumann FBumann mentioned this pull request Mar 29, 2025
Closed
@baumbude
Copy link
Collaborator

baumbude commented Apr 3, 2025

Verstehe die Motivation. Die Frage ist halt wirklich, ob man sich damit nicht eine Möglichkeit verbaut, das Modell übersichtlicher zu strukturieren/Gleichungen zu filtern etc.
Bsp: Wenn man in Komponente sowohl investment als auch conversion mit jeweils 10 pieces hat, wird es ggf. unübersichtlich...

@FBumann
Copy link
Member Author

FBumann commented Apr 3, 2025

Verstehe die Motivation. Die Frage ist halt wirklich, ob man sich damit nicht eine Möglichkeit verbaut, das Modell übersichtlicher zu strukturieren/Gleichungen zu filtern etc. Bsp: Wenn man in Komponente sowohl investment als auch conversion mit jeweils 10 pieces hat, wird es ggf. unübersichtlich...

Ich bin der Meinung dass es dadurch nu übersichtlicher wird.
SO sind nämlich alle variablen an einem Ort in gleich langen listen.
Davor war war es weniger einheitlich strukturiert.

@FBumann
Copy link
Member Author

FBumann commented Sep 11, 2025

#294

@FBumann FBumann added the Not in Focus This seems reasonable, but we are not working on it at the moment. label Sep 23, 2025
@FBumann FBumann deleted the branch next/major October 13, 2025 21:41
@FBumann FBumann closed this Oct 13, 2025
@FBumann FBumann deleted the feature/piecewise branch November 19, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baumbude baumbude Awaiting requested review from baumbude

Assignees

No one assigned

Labels

Not in Focus This seems reasonable, but we are not working on it at the moment.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FBumann @baumbude