-
Notifications
You must be signed in to change notification settings - Fork 546
docs: kafka: add Windows SSPI support for MSK IAM authentication #2313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: BP Cheng <bp_cheng@hotmail.com>
📝 WalkthroughWalkthroughDocumentation update to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
pipeline/outputs/kafka.md (2)
5-5: Fix plugin type reference in introductory text.Line 5 references "Kafka input plugin" but this documentation is for the Kafka output plugin. This inconsistency may confuse readers.
Suggested fix:
-In Fluent Bit 4.0.4 and later, the Kafka input plugin supports authentication with AWS MSK IAM, enabling integration with Amazon MSK (Managed Streaming for Apache Kafka) clusters that require IAM-based access. +In Fluent Bit 4.0.4 and later, the Kafka output plugin supports authentication with AWS MSK IAM, enabling integration with Amazon MSK (Managed Streaming for Apache Kafka) clusters that require IAM-based access.
290-293: Removeaws_msk_iam_cluster_arnfrom the AWS MSK IAM configuration example.In Fluent Bit v4.0.4+, the
aws_msk_iam_cluster_arnparameter was removed. The minimal required configuration for AWS MSK IAM authentication isaws_msk_iam: trueonly (the region is auto-detected from the broker hostname). Update the example at lines 290-293 to remove theaws_msk_iam_cluster_arnline, and update the parameter table to reflect that this parameter is no longer used.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pipeline/outputs/kafka.md
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: kalavt
Repo: fluent/fluent-bit-docs PR: 2294
File: pipeline/inputs/kafka.md:147-168
Timestamp: 2025-12-12T14:30:18.461Z
Learning: In Fluent Bit v4.0.4+, when using AWS MSK IAM authentication (rdkafka.sasl.mechanism: aws_msk_iam), the rdkafka.security.protocol is automatically set to SASL_SSL and the AWS region is auto-detected from the broker hostname for standard MSK endpoints. The aws_msk_iam_cluster_arn parameter was removed - users only need to set rdkafka.sasl.mechanism: aws_msk_iam (and optionally aws_region for custom DNS/PrivateLink).
🔇 Additional comments (1)
pipeline/outputs/kafka.md (1)
248-251: Windows SSPI support table structure looks good.The platform-specific Build Requirements table appropriately distinguishes between Linux/macOS and Windows configurations, with clear notes about SSPI and OpenSSL/TLS requirements for Windows. This aligns well with the PR objective to document Windows SSPI support.
docs: kafka: add Windows SSPI support for MSK IAM authentication
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.