fix: Add IPv6 support for bind parameter #240
Open
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two IPv6-related bugs when using bind='::': 1. Log message construction: Previously created invalid URL 'http://:::24231' instead of 'http://[::]:24231' 2. Worker aggregation: When bind is '::', the code tried to connect to '::' directly instead of converting it to '::1' (IPv6 localhost), causing connection failures Changes: - Add bracket notation for IPv6 addresses in log messages - Convert '::' to '::1' for inter-worker communication - Maintain backward compatibility with IPv4 addresses Fixes fluent#229 Signed-off-by: Jesse Awan <jesse.awan@sap.com>
I501307
force-pushed
the
fix/ipv6-bind-support
branch
from
82ad754 to
be6af88
Compare
Author
|
Could a maintainer please add the bug label? This fixes a crash affecting all Fluentd versions when binding to IPv6 addresses. |
Author
|
@Watson1978 @kenhys isn't this more or less the same problem : fluent/fluentd#5239 |
Contributor
|
Can you add the tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two IPv6-related bugs when using bind='::':
Log message construction: Previously created invalid URL 'http://:::24231' instead of 'http://[::]:24231'
Worker aggregation: When bind is '::', the code tried to connect to '::' directly instead of converting it to '::1' (IPv6 localhost), causing connection failures
Changes:
Fixes #229