[Tizen] Re-implemented render external texture gl for impeller to avoid change FlutterOpenGLTexture and use deprecated api#23
Open
xiaowei-guan wants to merge 4 commits intoflutter-tizen:flutter-3.38.3from
Conversation
…id change FlutterOpenGLTexture and use deprecated api
JSUYA
reviewed
Jan 23, 2026
Member
JSUYA
left a comment
There was a problem hiding this comment.
Sorry for the late review.
I left a comment. Please check it.
engine/src/flutter/shell/platform/embedder/embedder_external_texture_gl.cc
Outdated
Show resolved
Hide resolved
JSUYA
reviewed
Jan 29, 2026
engine/src/flutter/shell/platform/embedder/embedder_external_texture_gl.cc
Show resolved
Hide resolved
engine/src/flutter/shell/platform/embedder/embedder_external_texture_gl.cc
Outdated
Show resolved
Hide resolved
engine/src/flutter/shell/platform/embedder/embedder_external_texture_gl.cc
Show resolved
Hide resolved
engine/src/flutter/shell/platform/embedder/embedder_external_texture_gl.h
Outdated
Show resolved
Hide resolved
JSUYA
approved these changes
Feb 3, 2026
Member
JSUYA
left a comment
There was a problem hiding this comment.
I'm a little worried because there are a lot of code diffs...
Author
I think this patch has two advantages:
|
Member
|
please rebase to 3.38.8 branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have supported render external texture gl for Impeller
flutter-tizen/engine#368
But this PR has two issues:
So I tried to revert offical PR to render external gl for impeller
flutter/engine#56277
But this PR doesn't work on Tizen platform, I think This PR may not have been verified.
To avoid change FlutterOpenGLTexture and use deprecated api, so I re-implemented render external texture gl for impeller based on this offical PR.
Fix flutter-tizen/embedder#131