-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[local_auth_darwin][UIScene] Add UIScene lifecycle support #10836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for the UIScene lifecycle to the local_auth_darwin plugin, ensuring compatibility with modern iOS apps while retaining support for older apps using the UIApplication lifecycle. This is achieved by adding a sceneDidBecomeActive delegate method and registering the plugin as a FlutterSceneLifeCycleDelegate. The changes also include updating the package version and SDK constraints. My review includes a suggestion to improve code maintainability by reducing duplication.
...h/local_auth_darwin/darwin/local_auth_darwin/Sources/local_auth_darwin/LocalAuthPlugin.swift
Show resolved
Hide resolved
vashworth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also migrate the example app using the app guide? https://docs.flutter.dev/release/breaking-changes/uiscenedelegate#migration-guide-for-flutter-apps
| #if os(iOS) | ||
| registrar.addApplicationDelegate(instance) | ||
| registrar.addSceneDelegate(instance) | ||
| #endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| #if os(iOS) | |
| registrar.addApplicationDelegate(instance) | |
| registrar.addSceneDelegate(instance) | |
| #endif | |
| registrar.addApplicationDelegate(instance) | |
| #if os(iOS) | |
| registrar.addSceneDelegate(instance) | |
| #endif |
registrar.addApplicationDelegate(instance) is not iOS specific, it also applies to macOS.
Adds support for the new Apple UIScene lifecycle while maintaining backward compatibility with apps that haven't migrated yet.
Fixes flutter/flutter#174411
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3