[file_selector_android] Remove deprecated usesCleartextTraffic#11057
[file_selector_android] Remove deprecated usesCleartextTraffic#11057mboetger wants to merge 6 commits intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request removes the android:usesCleartextTraffic="true" attribute from the <application> tag in the packages/file_selector/file_selector_android/example/android/app/src/debug/AndroidManifest.xml file. This change addresses the deprecation of the attribute and enhances security by preventing cleartext traffic, which is appropriate as the file selector functionality does not require it.
Removes deprecated usesCleartextTraffic and replaces it with a network configuration policy file.
Addresses: #182553
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].///).