Skip to content

Fix sitemap date formatting to fix build#13040

Merged
parlough merged 2 commits intomainfrom
fix/jaspr-0-22-2-build
Feb 6, 2026
Merged

Fix sitemap date formatting to fix build#13040
parlough merged 2 commits intomainfrom
fix/jaspr-0-22-2-build

Conversation

@parlough
Copy link
Member

@parlough parlough commented Feb 6, 2026

Jaspr 0.22.2 was recently released and appears to validate the format of the sitemap lastmod date at some point.

Also tighten dependency version constraints to ensure we're using the latest Jaspr version.

@parlough parlough requested review from a team and sfshaza2 as code owners February 6, 2026 06:35
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @parlough, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a build issue stemming from a recent Jaspr update by implementing a necessary fix for sitemap date formatting and updating several project dependencies. The changes ensure that the site builds successfully by adhering to the new, stricter sitemap validation rules and maintaining overall dependency compatibility.

Highlights

  • Sitemap Date Formatting Fix: The DateTime extension's formatted getter in data_processor.dart has been updated to ensure that month and day values are zero-padded (e.g., YYYY-MM-DD). This change addresses a build failure caused by stricter sitemap lastmod date validation introduced in Jaspr 0.22.2.
  • Dependency Version Updates: Various package dependencies have been updated to their latest compatible versions across site/pubspec.yaml and tool/dash_site/lib/src/utils.dart. Key updates include jaspr to ^0.22.2, build to ^4.0.4, http to ^1.6.0, meta to ^1.18.1, and several dev_dependencies such as build_runner, build_web_compilers, jaspr_builder, and sass. This ensures compatibility with the new Jaspr version and tightens version constraints.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • site/lib/src/loaders/data_processor.dart
    • Modified the formatted getter for DateTime to explicitly pad month and day values with leading zeros, ensuring a YYYY-MM-DD format for sitemap lastmod dates.
  • site/pubspec.yaml
    • Updated build from ^4.0.2 to ^4.0.4.
    • Updated http from ^1.5.0 to ^1.6.0.
    • Updated jaspr from ^0.22.1 to ^0.22.2.
    • Updated meta from ^1.17.0 to ^1.18.1.
    • Updated build_runner from ^2.10.2 to ^2.11.0.
    • Updated build_web_compilers from ^4.4.0 to ^4.4.9.
    • Updated jaspr_builder from ^0.22.1 to ^0.22.2.
    • Updated sass from ^1.97.2 to ^1.97.3.
  • tool/dash_site/lib/src/utils.dart
    • Updated the jaspr_cli activation version from ^0.22.1 to ^0.22.2.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a build failure related to sitemap date validation in a new Jaspr version. The changes correctly format the date to YYYY-MM-DD and update dependencies to the latest versions. The logic is sound. I've added one suggestion to make the date formatting code more concise by using a standard library function. The other changes are appropriate.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Feb 6, 2026

Visit the preview URL for this PR (updated for commit dbb9214):

https://flutter-docs-prod--pr13040-fix-jaspr-0-22-2-build-r2qbivxb.web.app

@parlough parlough merged commit bd31975 into main Feb 6, 2026
10 checks passed
@parlough parlough deleted the fix/jaspr-0-22-2-build branch February 6, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants