Skip to content

fix: NullPointerException BackgroundWorker.getDartTask #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ColinSchmale wants to merge 1 commit into from
Closed

fix: NullPointerException BackgroundWorker.getDartTask #635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 32 additions & 4 deletions ...ager_android/android/src/main/kotlin/dev/fluttercommunity/workmanager/BackgroundWorker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class BackgroundWorker(
}

private val dartTask
get() = workerParams.inputData.getString(DART_TASK_KEY)!!
get() = workerParams.inputData.getString(DART_TASK_KEY)

private val runAttemptCount = workerParams.runAttemptCount
private val randomThreadIdentifier = Random().nextInt()
Expand Down Expand Up @@ -86,11 +86,20 @@ class BackgroundWorker(
return@ensureInitializationCompleteAsync
}

val localDartTask = dartTask

if (localDartTask == null) {
val exception = IllegalStateException("Dart task is null")
WorkmanagerDebug.onExceptionEncountered(applicationContext, null, exception)
completer?.set(Result.failure())
return@ensureInitializationCompleteAsync
}

val dartBundlePath = flutterLoader.findAppBundlePath()

val taskInfo =
TaskDebugInfo(
taskName = dartTask,
taskName = localDartTask,
inputData = payload,
startTime = startTime,
callbackHandle = callbackHandle,
Expand Down Expand Up @@ -132,9 +141,18 @@ class BackgroundWorker(
) {
val fetchDuration = System.currentTimeMillis() - startTime

val localDartTask = dartTask

if (localDartTask == null) {
val exception = IllegalStateException("Dart task is null")
WorkmanagerDebug.onExceptionEncountered(applicationContext, null, exception)
completer?.set(Result.failure())
return
}

val taskInfo =
TaskDebugInfo(
taskName = dartTask,
taskName = localDartTask,
inputData = payload,
startTime = startTime,
)
Expand Down Expand Up @@ -175,7 +193,17 @@ class BackgroundWorker(
// Convert payload to the format expected by Pigeon (Map<String?, Object?>)
val pigeonPayload = payload.mapKeys { it.key as String? }.mapValues { it.value as Object? }

flutterApi.executeTask(dartTask, pigeonPayload) { result ->
val localDartTask = dartTask

if (localDartTask == null) {
val exception = IllegalStateException("Dart task is null")
WorkmanagerDebug.onExceptionEncountered(applicationContext, null, exception)

stopEngine(Result.failure(), exception.message)
return
}

flutterApi.executeTask(localDartTask, pigeonPayload) { result ->
when {
result.isSuccess -> {
val wasSuccessful = result.getOrNull() ?: false
Expand Down
Loading