Skip to content

fix(android): prevent PlatformException after initialize on first run (fixes #645) #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonathanduke wants to merge 1 commit into from
Closed

fix(android): prevent PlatformException after initialize on first run (fixes #645) #646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...ger_android/android/src/main/kotlin/dev/fluttercommunity/workmanager/WorkmanagerPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ private const val INIT_REQUIRED =
"You have not properly initialized the Flutter WorkManager Package. " +
"You should ensure you have called the 'initialize' function first!"

private const val INIT_FAILED =
"Workmanager.initialize failed because 'callbackHandle' was invalid."

/**
* Pigeon-based implementation of WorkmanagerHostApi for Android.
* Replaces the manual method channel and data extraction approach.
Expand Down Expand Up @@ -47,7 +50,14 @@ class WorkmanagerPlugin :
callback: (Result<Unit>) -> Unit,
) {
try {
preferenceManager.saveCallbackDispatcherHandleKey(request.callbackHandle)
val handle = request.callbackHandle
if (handle <= 0L) {
callback(Result.failure(Exception(INIT_FAILED)))
return
}

preferenceManager.saveCallbackDispatcherHandleKey(handle)
currentDispatcherHandle = handle
callback(Result.success(Unit))
} catch (e: Exception) {
callback(Result.failure(e))
Expand Down