Add support for custom health checks via CEL expressions #1389
Conversation
matheuscscp
force-pushed
the
cel-health-checks
branch
from
e42960b to
1230f07
Compare
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @matheuscscp 🏅
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
matheuscscp
force-pushed
the
cel-health-checks
branch
from
1230f07 to
e96dd90
Compare
| - apiVersion: bitnami.com/v1alpha1 | ||
| kind: SealedSecret | ||
| failed: status.conditions.filter(e, e.type == 'Synced').all(e, e.status == 'False') | ||
| current: status.conditions.filter(e, e.type == 'Synced').all(e, e.status == 'True') |
There was a problem hiding this comment.
@matheuscscp if there are multiple SealedSecret instances in the chart, will the helm release wait for all to reach the Synced status?
There was a problem hiding this comment.
This field is per type, not per object.
There was a problem hiding this comment.
@matheuscscp > This field is per type, not per object.
Yes, based on the declaration I got it but I am asking if the chart contains multiple SealedSecret will helm release wait for the SealedSecret type CR to be in successful terminal status?
Out of two SealedSecret CR present in the chart if one is taking more time to reach the terminal status, then I believe it will wait for that also. is my understanding correct?
There was a problem hiding this comment.
Flux always waits for all resources to become ready if no resources have failed so far. It fails fast if at least one resource fails.
Closes: #1382
Implements RFC-0009 for helm-controller.