Skip to content

fixed png images rendering issues for qrcode #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mohammadwasifbalti wants to merge 5 commits into from
Closed

fixed png images rendering issues for qrcode #1639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f149cc
fixed png images rendering issues for qrcode
Mohammadwasifbalti Aug 1, 2025
857820e
updated changelog.md
Mohammadwasifbalti Aug 1, 2025
3f4916c
some lines were missing so This is the final submission
Mohammadwasifbalti Aug 1, 2025
4275a3b
removed the smask for one test case
Mohammadwasifbalti Sep 9, 2025
79e7413
Merge branch 'master' into fix-png-image-embedding-and-sizing-issue
Mohammadwasifbalti Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,16 @@

### Unreleased

### [v0.17.3] - 2025-09-09

- fixed png images rendering issues for qrcode


### [v0.17.2] - 2025-08-30

- Fix rendering lists that spans across pages


### [v0.17.1] - 2025-05-02

- Fix null values in table cells rendering as `[object Object]`
Expand Down
2 changes: 1 addition & 1 deletion lib/image/png.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ class PNGImage {
}

finalize() {
if (this.alphaChannel) {
if (this.image.hasAlphaChannel && this.alphaChannel) {
const sMask = this.document.ref({
Type: 'XObject',
Subtype: 'Image',
Expand Down
13 changes: 0 additions & 13 deletions tests/unit/png.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,6 @@ describe('PNGImage', () => {
Type: 'XObject',
Width: 32,
DecodeParms: expect.any(PDFReference),
SMask: expect.any(PDFReference),
});

expect(img.obj.data.DecodeParms.data).toMatchObject({
Expand All @@ -246,18 +245,6 @@ describe('PNGImage', () => {
Columns: 32,
Predictor: 15,
});

expect(img.obj.data.SMask.data).toMatchObject({
BitsPerComponent: 8,
ColorSpace: 'DeviceGray',
Decode: [0, 1],
Filter: 'FlateDecode',
Height: 32,
Length: 16,
Subtype: 'Image',
Type: 'XObject',
Width: 32,
});
});

test('Grayscale', () => {
Expand Down