This repository was archived by the owner on May 12, 2025. It is now read-only.
Open
Conversation
….5 -> 3.3.4 Signed-off-by: Christian Niessner <144779930+cn-at-osmit@users.noreply.github.com>
….4 -> 3.4.0 Signed-off-by: Christian Niessner <144779930+cn-at-osmit@users.noreply.github.com>
|
Good stuff @cn-at-osmit ! This saved us a bunch of time. One minor thing I noticed is the ssh server doesn't actually start. @Component
class ShellStartupListener(val server: SshServer) {
val logger: Logger = LoggerFactory.getLogger(ShellStartupListener::class.java)
@EventListener(ApplicationReadyEvent::class)
fun onApplicationStartup() {
if (!server.isStarted) {
logger.warn("SSH server not started, starting it now")
server.start()
}
}
}I can provide more detail if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
we had to upgrade our project to a supported spring boot release, so we had to get ssh-shell-spring-boot working with it.
This is the second PR (based on the #403 ) where we made the step between spring-boot 3.3.8 -> 3.4.2. It also updates spring-shell 3.3.4 -> 3.4.0.
All junit tests succeed and also some basic interactive tests are working.
Bye,
Chris