Skip to content

Comments

Continue Data Processing Even if one scripts fails#299

Merged
LukasWallrich merged 1 commit intomasterfrom
dataprocess
Mar 26, 2025
Merged

Continue Data Processing Even if one scripts fails#299
LukasWallrich merged 1 commit intomasterfrom
dataprocess

Conversation

@richarddushime
Copy link
Contributor

@richarddushime richarddushime commented Mar 25, 2025

Description

I checked and found that some scripts are failing sometimes , like google-scholar etc..
or we need the remaining scripts data

Fixes # (issue)

Type of Change

  • Documentation/Contents/grammar update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tested Locally
  • Manual review / previewed on staging.forrt.org content/webpage changes
  • Not Tested yet

Checklist for Content Editors and Non-Developers

  • The content is clear, accurate, and follows community guidelines.
  • All updated content has been previewed on the staging site.
  • All links, references, and formatting have been checked for correctness.
  • The change aligns with the overall style and communication goals.
  • No broken links in text/content

Checklist for Developers:

  • I have attempted to stay aligned to related code in this repository rather than reinventing the wheel.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

Additional Notes

@richarddushime richarddushime requested a review from a team as a code owner March 25, 2025 09:39
@github-actions github-actions bot added the cicd Relevant to GitHub workflows label Mar 25, 2025
@github-actions
Copy link
Contributor

👍 All image files/references (if any) are in webp format, in line with our policy.

@richarddushime
Copy link
Contributor Author

like now the google scholar script is failing

Run python3 scripts/gs-cite/google_scholar.py
Traceback (most recent call last):
File "/home/runner/work/forrtproject.github.io/forrtproject.github.io/scripts/gs-cite/google_scholar.py", line 10, in
raise ValueError("API key is missing. Please set the SERPAPI environment variable.")
ValueError: API key is missing. Please set the SERPAPI environment variable.
Error: Process completed with exit code 1.

@richarddushime
Copy link
Contributor Author

Now the workflow can work and leaves a notification about the failed script

dp

Copy link
Contributor

@LukasWallrich LukasWallrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - that's a very important improvement. I would like 'louder' notification thought but still merging for now.

@LukasWallrich LukasWallrich merged commit 196f15b into master Mar 26, 2025
6 checks passed
@LukasWallrich LukasWallrich deleted the dataprocess branch March 26, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cicd Relevant to GitHub workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants