feat: lora for accelerated MoE - limited #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
fabianlim
reviewed
Apr 17, 2025
plugins/accelerated-moe/src/fms_acceleration_moe/utils/scattermoe.py
Outdated
Show resolved
Hide resolved
fabianlim
reviewed
Apr 17, 2025
plugins/accelerated-moe/src/fms_acceleration_moe/utils/scattermoe.py
Outdated
Show resolved
Hide resolved
fabianlim
reviewed
Apr 17, 2025
plugins/accelerated-moe/src/fms_acceleration_moe/utils/scattermoe.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
fabianlim
reviewed
Apr 17, 2025
plugins/accelerated-moe/src/fms_acceleration_moe/utils/checkpoint_utils.py
Show resolved
Hide resolved
fabianlim
reviewed
Apr 17, 2025
plugins/accelerated-moe/src/fms_acceleration_moe/utils/checkpoint_utils.py
Show resolved
Hide resolved
fabianlim
reviewed
Apr 17, 2025
plugins/accelerated-moe/src/fms_acceleration_moe/utils/scattermoe.py
Outdated
Show resolved
Hide resolved
fabianlim
requested changes
Apr 17, 2025
Contributor
fabianlim
left a comment
fabianlim
left a comment
There was a problem hiding this comment.
we need to be careful not to disable the ScatterMoE if you do not want to lora train the experts. Some changes are are required to fix that issue
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
fabianlim
reviewed
Apr 18, 2025
plugins/accelerated-moe/src/fms_acceleration_moe/utils/scattermoe.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
fabianlim
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limited version of #139 without support for router or expert layers