Skip to content

fix: add global step number in hf moe chpt #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashokponkumar merged 2 commits into from
Nov 24, 2025
Merged

fix: add global step number in hf moe chpt #643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1b3726
fix: add global step number in hf moe chpt
YashasviChaurasia Nov 24, 2025
50f792e
Merge branch 'main' into fix-naming
YashasviChaurasia Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tuning/config/acceleration_configs/fast_moe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def on_save(
def checkpoint(checkpoint_dir, save_dir, is_intermediate: bool = True):
if is_intermediate:
hf_converted_output_dir = os.path.join(
save_dir, "hf_converted_checkpoint"
save_dir, f"safetensors-{state.global_step}"
)
else:
hf_converted_output_dir = save_dir
Expand Down
2 changes: 1 addition & 1 deletion tuning/trainercontroller/callback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,7 @@ def on_save(
kwargs["is_final"] = False

base_path = kwargs["path"]
hf_converted_path = os.path.join(base_path, "hf_converted_checkpoint")
hf_converted_path = os.path.join(base_path, f"safetensors-{state.global_step}")

if os.path.isdir(hf_converted_path):
kwargs["hf_path"] = hf_converted_path
Expand Down